전략 시간봉 오류 수정

This commit is contained in:
Macbook
2026-05-27 15:49:56 +09:00
parent 63693d47c0
commit e86142dad5
5 changed files with 139 additions and 11 deletions
@@ -71,11 +71,21 @@ public class StrategyConditionTimeframeService {
private void collectFromNode(JsonNode node, Set<String> out) { private void collectFromNode(JsonNode node, Set<String> out) {
if (node == null || node.isNull()) return; if (node == null || node.isNull()) return;
if (collectTimeframesFromNode(node, out)) return;
// TIMEFRAME 래핑 없는 레거시 트리 — 기본 1m
out.add("1m");
}
/**
* 트리에서 TIMEFRAME 노드를 수집. 발견 시 true.
*/
private boolean collectTimeframesFromNode(JsonNode node, Set<String> out) {
if (node == null || node.isNull()) return false;
String type = node.path("type").asText(""); String type = node.path("type").asText("");
if ("TIMEFRAME".equals(type)) { if ("TIMEFRAME".equals(type)) {
out.add(LiveStrategyTimeframeService.normalize(node.path("candleType").asText("1m"))); out.add(LiveStrategyTimeframeService.normalize(node.path("candleType").asText("1m")));
return; return true;
} }
if ("AND".equals(type) || "OR".equals(type)) { if ("AND".equals(type) || "OR".equals(type)) {
@@ -85,23 +95,22 @@ public class StrategyConditionTimeframeService {
for (JsonNode tf : children) { for (JsonNode tf : children) {
out.add(LiveStrategyTimeframeService.normalize(tf.path("candleType").asText("1m"))); out.add(LiveStrategyTimeframeService.normalize(tf.path("candleType").asText("1m")));
} }
return; return true;
} }
boolean found = false;
for (JsonNode child : children) { for (JsonNode child : children) {
collectFromNode(child, out); found |= collectTimeframesFromNode(child, out);
} }
return; return found;
} }
} }
JsonNode child = node.path("child"); JsonNode child = node.path("child");
if (!child.isMissingNode() && !child.isNull()) { if (!child.isMissingNode() && !child.isNull()) {
collectFromNode(child, out); return collectTimeframesFromNode(child, out);
return;
} }
// 단일 START(기본 1m) 또는 TIMEFRAME 래핑 없는 트리 return false;
out.add("1m");
} }
private static boolean allTimeframeChildren(JsonNode children) { private static boolean allTimeframeChildren(JsonNode children) {
@@ -100,9 +100,35 @@ public class StrategyTriggerBranchEvaluator {
} }
} }
JsonNode wrapped = findTimeframeWrapper(node);
if (wrapped != null) {
String ct = LiveStrategyTimeframeService.normalize(wrapped.path("candleType").asText("1m"));
JsonNode sub = firstChild(wrapped);
return new BranchScope("SINGLE", List.of(new BranchDef(ct, sub != null && !sub.isNull() ? sub : node)));
}
return new BranchScope("SINGLE", List.of(new BranchDef("1m", node))); return new BranchScope("SINGLE", List.of(new BranchDef("1m", node)));
} }
/** 레거시 DSL — 루트가 TIMEFRAME이 아닐 때 하위 TIMEFRAME 래퍼 탐색 */
private static JsonNode findTimeframeWrapper(JsonNode node) {
if (node == null || node.isNull()) return null;
if ("TIMEFRAME".equals(node.path("type").asText(""))) return node;
JsonNode children = node.path("children");
if (children.isArray()) {
for (JsonNode child : children) {
JsonNode found = findTimeframeWrapper(child);
if (found != null) return found;
}
}
JsonNode child = node.path("child");
if (!child.isMissingNode() && !child.isNull()) {
return findTimeframeWrapper(child);
}
return null;
}
private static JsonNode firstChild(JsonNode timeframeNode) { private static JsonNode firstChild(JsonNode timeframeNode) {
JsonNode children = timeframeNode.path("children"); JsonNode children = timeframeNode.path("children");
if (children.isArray() && !children.isEmpty()) return children.get(0); if (children.isArray() && !children.isEmpty()) return children.get(0);
@@ -0,0 +1,75 @@
package com.goldenchart.service;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.goldenchart.entity.GcStrategy;
import com.goldenchart.repository.GcStrategyRepository;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Spy;
import org.mockito.junit.jupiter.MockitoExtension;
import java.util.Optional;
import java.util.Set;
import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.when;
@ExtendWith(MockitoExtension.class)
class StrategyConditionTimeframeServiceTest {
@Mock
private GcStrategyRepository strategyRepo;
@Spy
private ObjectMapper objectMapper = new ObjectMapper();
@InjectMocks
private StrategyConditionTimeframeService service;
@BeforeEach
void stubStrategy() {
GcStrategy strategy = new GcStrategy();
strategy.setId(1L);
strategy.setBuyConditionJson("""
{
"type": "TIMEFRAME",
"candleType": "5m",
"children": [{
"type": "CONDITION",
"condition": { "indicatorType": "RSI", "period": 14 }
}]
}
""");
strategy.setSellConditionJson(null);
when(strategyRepo.findById(1L)).thenReturn(Optional.of(strategy));
}
@Test
void collectForStrategy_readsTimeframeFromDsl() {
Set<String> tfs = service.collectForStrategy(1L);
assertEquals(Set.of("5m"), tfs);
assertTrue(service.usesTimeframe(1L, "5m"));
assertFalse(service.usesTimeframe(1L, "1m"));
}
@Test
void collectForStrategy_legacyTreeDefaultsTo1m() {
GcStrategy legacy = new GcStrategy();
legacy.setId(2L);
legacy.setBuyConditionJson("""
{
"type": "AND",
"children": [{
"type": "CONDITION",
"condition": { "indicatorType": "RSI", "period": 14 }
}]
}
""");
when(strategyRepo.findById(2L)).thenReturn(Optional.of(legacy));
assertEquals(Set.of("1m"), service.collectForStrategy(2L));
}
}
@@ -24,6 +24,7 @@ import { findLogicNode, getIndicatorPeriodLabel } from '../utils/strategyFlowLay
import { import {
decodeConditionForEditor, decodeConditionForEditor,
encodeConditionForSave, encodeConditionForSave,
mergeStartMetaForLoad,
addExtraStartSection, addExtraStartSection,
hasMultipleStartSections, hasMultipleStartSections,
normalizeStartCombineOp, normalizeStartCombineOp,
@@ -500,7 +501,7 @@ export default function StrategyEditorPage({ theme }: Props) {
setBuyLayout({ setBuyLayout({
positions: stored?.buy.positions ?? {}, positions: stored?.buy.positions ?? {},
edgeHandles: stored?.buy.edgeHandles ?? {}, edgeHandles: stored?.buy.edgeHandles ?? {},
startMeta: stored?.buy.startMeta ?? buyDecoded.startMeta, startMeta: mergeStartMetaForLoad(buyDecoded.startMeta, stored?.buy.startMeta),
extraStartIds: stored?.buy.extraStartIds?.length ? stored.buy.extraStartIds : buyDecoded.extraStartIds, extraStartIds: stored?.buy.extraStartIds?.length ? stored.buy.extraStartIds : buyDecoded.extraStartIds,
extraRoots: stored?.buy.extraRoots && Object.keys(stored.buy.extraRoots).length extraRoots: stored?.buy.extraRoots && Object.keys(stored.buy.extraRoots).length
? stored.buy.extraRoots ? stored.buy.extraRoots
@@ -510,7 +511,7 @@ export default function StrategyEditorPage({ theme }: Props) {
setSellLayout({ setSellLayout({
positions: stored?.sell.positions ?? {}, positions: stored?.sell.positions ?? {},
edgeHandles: stored?.sell.edgeHandles ?? {}, edgeHandles: stored?.sell.edgeHandles ?? {},
startMeta: stored?.sell.startMeta ?? sellDecoded.startMeta, startMeta: mergeStartMetaForLoad(sellDecoded.startMeta, stored?.sell.startMeta),
extraStartIds: stored?.sell.extraStartIds?.length ? stored.sell.extraStartIds : sellDecoded.extraStartIds, extraStartIds: stored?.sell.extraStartIds?.length ? stored.sell.extraStartIds : sellDecoded.extraStartIds,
extraRoots: stored?.sell.extraRoots && Object.keys(stored.sell.extraRoots).length extraRoots: stored?.sell.extraRoots && Object.keys(stored.sell.extraRoots).length
? stored.sell.extraRoots ? stored.sell.extraRoots
@@ -538,6 +539,7 @@ export default function StrategyEditorPage({ theme }: Props) {
return; return;
} }
setSaveNameError(false); setSaveNameError(false);
if (editorMode === 'graph') layoutFlushRef.current?.();
const encodedBuy = encodeConditionForSave(buyEditorState); const encodedBuy = encodeConditionForSave(buyEditorState);
const encodedSell = encodeConditionForSave(sellEditorState); const encodedSell = encodeConditionForSave(sellEditorState);
if (!encodedBuy && !encodedSell) { showSnack('조건을 최소 1개 추가하세요', false); return; } if (!encodedBuy && !encodedSell) { showSnack('조건을 최소 1개 추가하세요', false); return; }
+17 -1
View File
@@ -161,7 +161,6 @@ export function encodeConditionForSave(state: EditorConditionState): LogicNode |
if (branches.length === 0) return null; if (branches.length === 0) return null;
if (branches.length === 1) { if (branches.length === 1) {
const { candleType, root } = branches[0]; const { candleType, root } = branches[0];
if (normalizeStartCandleType(candleType) === DEFAULT_START_CANDLE) return root;
return wrapTimeframe(candleType, root); return wrapTimeframe(candleType, root);
} }
@@ -257,3 +256,20 @@ export function collectEditorBranches(state: EditorConditionState): ConditionBra
export function collectDslBranches(dsl: LogicNode | null): ConditionBranch[] { export function collectDslBranches(dsl: LogicNode | null): ConditionBranch[] {
return collectEditorBranches(decodeConditionForEditor(dsl)); return collectEditorBranches(decodeConditionForEditor(dsl));
} }
/**
* 전략 로드 시 startMeta 병합 — DB DSL에서 복원한 시간봉이 localStorage보다 우선.
*/
export function mergeStartMetaForLoad(
decoded: Record<string, StartNodeMeta>,
stored?: Record<string, StartNodeMeta> | null,
): Record<string, StartNodeMeta> {
const merged: Record<string, StartNodeMeta> = {
...defaultStartMeta(),
...stored,
};
for (const [startId, meta] of Object.entries(decoded)) {
merged[startId] = { candleType: normalizeStartCandleType(meta.candleType) };
}
return merged;
}